Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive unit tests for the TextDetector class to verify its ability to detect text across various Unicode encodings. The tests cover UTF-8, UTF-16 (both LE and BE), and UTF-32 (both LE and BE) with BOM markers, including both valid text scenarios and invalid character scenarios.
- Adds test coverage for TextDetector::isText() method across all supported Unicode encodings
- Tests both positive cases (valid text with BOM) and negative cases (text with invalid control characters)
- Integrates the new test file into the CMake build system
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/TextDetectorTest.cpp | New comprehensive test suite covering all Unicode encoding scenarios for TextDetector |
| test/CMakeLists.txt | Adds the new test file to the build configuration |
| include/kf/TextDetector.h | Adds documentation comment explaining the TextDetector class functionality |
SergiusTheBest
requested changes
Aug 12, 2025
SergiusTheBest
requested changes
Aug 13, 2025
SergiusTheBest
approved these changes
Aug 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task: https://jira.dev.local/jira/browse/KF-25